Insights and outlooks on software development


Test smells

Thursday, February 21, 2008 by Thomas L

1. Having to explicitly set

ServiceLocator.TheService = MyMock

in the setup and doing


in teardown points to the fact the my tested code hasn't yet matured into having its own context (preferrably set via Dependency Injection)

2. When a repository holds state, something is really wrong (and it really hurts to refactor out that(ouch))

3. Don't use easy getters in your domain model objects that hide your repository gets, i.e. using


when that call does

return theOtherDomainRepository.findOtherInstanceById(this.otherId)

Filed under having  

0 kommentarer: